mwish

icon indicating an email [email protected]

icon location China, Jiangxi Province, Nanchang icon location So high, so low, so many things to know.

Results 326 comments of mwish

GH-43994: [C++][Parquet] Fix schema conversion from two-level encoding nested list

Yes. It's so tricky, I think we can just copying the Java code directly, lol

GH-43994: [C++][Parquet] Fix schema conversion from two-level encoding nested list

What about this line: https://github.com/apache/parquet-java/blob/aec7bc64dffa373db678ab2fc8b46565b4c011a5/parquet-avro/src/main/java/org/apache/parquet/avro/AvroSchemaConverter.java#L587 ?

GH-43994: [C++][Parquet] Fix schema conversion from two-level encoding nested list

> I think we are just missing check of this line This fixing itself LGTM, but I just think should we test and align more...

GH-43994: [C++][Parquet] Fix schema conversion from two-level encoding nested list

> Where is this in the Parquet spec? I cannot find a [similar example](https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#lists). The wording of the spec is very ambigious: > If the repeated field is not a...

GH-43994: [C++][Parquet] Fix schema conversion from two-level encoding nested list

@wgtmac Would you mind check testing file and add one if not exists in `parquet-testing`?

GH-44464: [C++] Added rvalue-reference-qualified overload for arrow::Result::status() returning value instead of reference

Will merge this if no negative comment tonight

GH-44464: [C++] Added rvalue-reference-qualified overload for arrow::Result::status() returning value instead of reference

Thanks all, merged

GH-42971: [C++] Parquet stream writer: Allow writing BYTE_ARRAY with converted type NONE

mind: 1. a test for this 2. Mark this pr for parquet stream writer?

GH-42971: [C++] Parquet stream writer: Allow writing BYTE_ARRAY with converted type NONE

> Is it possible to use `std::basic_string_view` ~or `std::basic_string_view`~? generally std::byte, char and uint8_t can be safely casted

GH-41764: [Parquet][C++] Support future logical types in the Parquet reader

Just ping me if this is ready