mwish

Results 249 comments of mwish
trafficstars

> Yes it is. I didn't find any volatile type qualifier, atomic variables or mutex in libart. Although libart is great, I guess it shouldn't be thread safe. If you...

Update: After hacking some brpc code and restart the machine, we downsample the `signal` in bthread, and the performance works better.

> > Update: After hacking some brpc code and restart the machine, we downsample the `signal` in bthread, and the performance works better. > > what hacks did you make?...

> Why put `bthread_flush()` to src/bthread/unstable.h? > > Under what conditions `NOSIGNAL` is he better? Are there any experimental data? @renguoqing I'm not a brpc committer, So I don't know...

The experimental data depends on workload. We're running so many lightweight task here, so we can downsample it to 1%. If there are lots of CPU boundary task, we think...

> @mapleFU This is quite a good practice. Can you contribute a PR? That might help more people. Glad to contribute to brpc. But the code maybe ugly. I'll try...

@wyfcyx Hi, 我在 #135 修了一下这个,可以看一看嘛(。ì _ í。)

@wyfcyx 新年快乐!mind take a look?

Seems that redis implement `--bigkey` as a client tool: https://github.com/redis/redis/blob/unstable/src/redis-cli.c#L8257 , it will send `scan` to sample the bigkeys. Maybe I can try to test using `--bigkey` in client in...

@git-hulk @PragmaTwice can this patch be closed now? Sinces kvrocks is already using C++17 and RocksDB 7.x