mwish comments

Results 326 comments of


                                            mwish

Blocking commands may block permanently due to lost wakeup

I forgot this a bit, is this issue fixed?

Blocking commands may block permanently due to lost wakeup

@RiversJin tells me and I just realized that Blocking commands might need a mechenism for lock and blocking. Some commands, like bzpop, would block on multiple keys. If multiple bzpop...

Blocking commands may block permanently due to lost wakeup

> We can try using MultiLockGuard to get the locks in the same order That's not lock, I think "BlockKeys" might following the same ordering? Or we should have a...

Blocking commands may block permanently due to lost wakeup

The blockKeys itself might not blocking, my bad, this can(and might should) be handled by well-designed sequence

Blocking commands may block permanently due to lost wakeup

Aha, you're right. So this **should** be fixed after that. Maybe we can also denote that the lock should be held when `StartBlocking` and `OnWrite` called

Index Structure Transaction Supports

cc @PragmaTwice @PokIsemaine

TSAN: LogUtil::GetLogPrefix data race

@Huberyxiao would you mind take a look?

[C++] Pass shared_ptr<DataType> by value to parametric type constructors

@singh1203 feel free to check and add some

GH-43124: [C++] Initialize offset vector head as 0 after memory allocated in grouper.cc

Thanks for the contribution! It would be better if having a test to reproduce the problem?

GH-43124: [C++] Initialize offset vector head as 0 after memory allocated in grouper.cc

https://github.com/apache/arrow/pull/43123/commits/bf2aff0822764279eb6834c3346c7c4e684d0b2b Didn't you updated this successfully?