mwish comments

Results 249 comments of


                                            mwish

trafficstars

GH-34785: [C++][Parquet] Parquet Bloom Filter Writer Implementation

@wgtmac @emkornfield @pitrou would you mind take a look again?

GH-34785: [C++][Parquet] Parquet Bloom Filter Writer Implementation

@wgtmac Would you mind take a look again?

GH-34785: [C++][Parquet] Parquet Bloom Filter Writer Implementation

Will continue this weekend :-)

GH-34785: [C++][Parquet] Parquet Bloom Filter Writer Implementation

@pitrou @wgtmac @emkornfield Would you mind take a look?

GH-34785: [C++][Parquet] Parquet Bloom Filter Writer Implementation

I'm quite busy these few days but I promise I would try my best to check this in this month This would not be in 17.0.0 release

GH-34785: [C++][Parquet] Parquet Bloom Filter Writer Implementation

@emkornfield I've try to resolve the comment For bloom filter quality, this patch I think just static config should be a start point, I've create an issue for that: https://github.com/apache/arrow/issues/43138

GH-34785: [C++][Parquet] Parquet Bloom Filter Writer Implementation

@pitrou @wgtmac This patch is ready for review, would you mind also take a look?

GH-34785: [C++][Parquet] Parquet Bloom Filter Writer Implementation

Two need fix: ``` /arrow/cpp/src/parquet/bloom_filter.h:118: error: The following parameter of parquet::BloomFilter::Hash(const FLBA &value, uint32_t type_len) const is not documented: parameter 'type_len' (warning treated as error, aborting now) ``` ``` D:/a/arrow/arrow/build/cpp/src/parquet/CMakeFiles/parquet_shared.dir/Unity/unity_3_cxx.cxx...

GH-34785: [C++][Parquet] Parquet Bloom Filter Writer Implementation

@pitrou @wgtmac @emkornfield Sorry for late reply, I believe all comments are replyed or fixed now. Now the bloom filter becoming map in all use cases, since it would be...

GH-34785: [C++][Parquet] Parquet Bloom Filter Writer Implementation

Rebased, ready for review now