mwish comments

Results 326 comments of


                                            mwish

GH-46677: [C++] Expose an BinaryViewBuilder interface for append a binary and multiple subslice

Gentle ping @pitrou

GH-46677: [C++] Expose an BinaryViewBuilder interface for append a binary and multiple subslice

> Isn't this approach wasteful? If you have lots of strings

GH-46677: [C++] Expose an BinaryViewBuilder interface for append a binary and multiple subslice

> Is it a win, though? If most Parquet strings are

GH-46677: [C++] Expose an BinaryViewBuilder interface for append a binary and multiple subslice

So can we start to review this? We can set a ratio when average length > 12 or > 20

GH-46677: [C++] Expose an BinaryViewBuilder interface for append a binary and multiple subslice

Looks (1) would work in buffer style api, but for parquet reader, it might append buffer one by one. The (2) is a good way for compute, but here I...

feat: support maxmemory-clients config

> want to discuss how we can implement this feature. My idea is to count client memory within each worker (using libevent's callback to count evbuffer) to avoid locking across...

Add backward compat nested file

@wgtmac do we have existing test file for legacy infering?

feat: support limit WriteBatch size

I think it's good. Another problem is that we may need type cast between `Status` and `rocksdb::Status`. We can make a new issue here.

feat: support limit WriteBatch size

> Nope. They can be done by GET_OR_RET. So `GET_OR_RET` can also handle the case for pure "Status"? Besides, what about err from rocksdb?

GH-43070: [C++][Parquet] Check for valid ciphertext length to prevent segfault

The code LGTM, but I'm not familiar with decrypt module. So @wgtmac @pitrou for help