mwish

I'd like to follow the testing here: https://github.com/apache/parquet-mr/blob/master/parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestDataPageV1Checksums.java @pitrou

> This actually seems more complicated to implement (you have to replicate details of the file format in the tests). Also, without reference files we wouldn't test that different implementations...

@pitrou @kou Hi, so should I put crc to vendored or util?

By the way, can someone tell me that how can I run CI on my PC?

Let me fix this ci...

https://github.com/apache/incubator-kvrocks/pull/707 @PragmaTwice This pr solve part of this problem. There are still some callings in `GetSlotNumFromKey`. Maybe cast `Slice` to `std::string_view`, and using it's `find` and `subslice` can solve this....

Which the help of `string_view` the code can be simplified: ``` c++ uint16_t GetSlotNumFromKey(const std::string &key) { auto tag = GetTagFromKey(key); if (tag.empty()) { tag = key; } auto crc...

I wonder why kvrocks' `Status` uses `std::string`, it would be large, likely 24B on stack ( for example: https://github.com/llvm-mirror/libcxx/blob/master/include/string#L765-L784 ) When I gothrough the code of project, I found that...

Hi hulk, after reading document and code of redis (mainly https://github.com/redis/redis/blob/unstable/src/networking.c#L3432 ), I found that `hello` defines the protocol redis use ( RESP2 or RESP3), and return the data via...

> @mapleFU You're right that we only implemented RESP2 and have no plan to implement RESP3 recently. The main purpose of this command is to compatible with some Redis clients,...