Chen Liang
Chen Liang
Now looking at #2648, renaming the current enum for beneficial harmful and neutral to category is good. The other two renames though I still object to.
This sounds more like a detection range for attack target than a valid attack range; like you can shoot a bow like a mortar to hit target behind a wall,...
Hmm, I now think we should call save games "save game" explicitly than using ambiguous "level". I recall that now level is mainly `LevelProperties` (name from `level.dat`), which is an...
Imo, `create` conveys that a new instance is always returned, while `of` can sometimes reuse existing instances for immutable objects.
unpick was separate not only because it was experimental but it was slightly slower.
Another old usage of `REGISTRY_CODEC` is where a typed object has its type read from the registry with id and then dispatches the rest of the object with the type....
@apple502j: var ints are not simply implementation details. If there's a list of ints like uuid, it's preferable to be written as regular int array given its uniform distribution. var...
This isn't really impactful as this is clarifying and there is no fixed-size-int arrays in `PacketByteBuf` that may cause major confusions.
Hmm, I think we come back to the old inheritance vs holding debate, like on whether we should carry the armor/tool material for an item through creating a subclass implementing...
@modmuss50 How do you think of these names? I personally think if you do create a class for definition of materials, you should make them hold two fields of `ArmorMaterial`...