Chen Liang
Chen Liang
Imo custom data is extremely vague. What is really "custom"? "data" is a meaningless suffix too. Imo a name like `writePersistentNbt` would be better (may not be the best), given...
> These are the methods called by `Entity#readNbt` and `Entity#writeNbt` and overridden in subclasses, right? yes
Now, a problem with naming them `REGISTRY_CODEC` is that there are other codecs, such as for biomes, that encodes/decodes the object definitions for dynamic registries. Need a more throughout look...
 Just don't make super tiny packages with very long paths like your last pr. Too deep path is a problem
what's the status of this now?
feel free to do one pr if you are willing to, or list the refactors and let someone else maintain a pr.
Imo this current package setup is fine. I will close this for now and reopen if someone comment here and point out some actual examples of what classes are badly...
This is actually more like a generic loot condition context than a loot table type. I think this is supplied whenever a loot condition (predicate) is evaluated.
Makes sense. I recommend linking to https://www.khronos.org/opengl/wiki/GLSL_Object for the source of the `ProgramObject` and `ShaderObject` names, as they are otherwise confusing to java-oriented programmers.
If they are decoupled enough from the loot tables, definitely should rename them. The ide renames can't cover every literal string in their code base.