yarn icon indicating copy to clipboard operation
yarn copied to clipboard

LivingEntity.getAttackDistanceScalingFactor name not helpful

Open liach opened this issue 4 years ago • 3 comments

This name is a bit too long and somewhat undescriptive (added in #533). It is a factor that changes detection distance of the parameter entity of this entity based on the invisibility, the skull wore, etc. Also need to rename ignoreDistanceScalingFactor in TargetPredicate.

What do you suggest for a more informative name?

liach avatar Jun 05 '21 14:06 liach

Perhaps getAttackRangeScale?

haykam821 avatar Jun 17 '21 15:06 haykam821

This sounds more like a detection range for attack target than a valid attack range; like you can shoot a bow like a mortar to hit target behind a wall, but you might not be able to detect the target in the first place.

liach avatar Jun 17 '21 15:06 liach

Since targets can be more than attacking, I would suggest getTargetRangeScale then.

haykam821 avatar Jun 17 '21 15:06 haykam821