Chen Liang
Chen Liang
I recall that setPos is the new way to replace old `x+=..` etc while the setPosition calls a few other associated methods for sync etc.
need a more throughout investigation on this, prob as part of the javadoc writing effort
imo dynamic registry manager would go to server.registry since it's loaded server-wide
hmm, then imo just putting it in the registry or its subpackages are fine. refer to where we place universal command stuff
again, why wouldn't this be light constants (min level, max level, default block level) or chunk (size, offset, etc) constants?
@modmuss50 In case you are interested, this is a diff between the old and new tiny v1 outputs: https://gist.github.com/5c15be78d81efd0c79ba8843fe65edcc it omits the entry if 3 names are the same and...
Drafting as I will base this on #2708; waiting for it to get merged first.
Current diff for v1 after sorting: https://gist.github.com/liach/50efe22a6aa24bf0087bca77f2b6df32 For v2, sorting is more complex. In addition, sorting probably should be done in mapping io; see https://github.com/FabricMC/mapping-io/issues/9
Fyi I will put this on hold given mapping-io's lack of ability to sort the mapping tree. The lack of auto name propagation to other namespaces is a minor issue...
Busy recently (so am not reviewing and submitting or even fixing my own prs). Will take some time to work on a better diff generator beyond text editor java programs...