StatusEffectInstance -> StatusEffect, SE -> SEType, SEType -> SECategory

[Juuxel]

(SE = StatusEffect) This would make it match things like Entity and EntityType.

[liach]

How do they show up in vanilla registry class?

[Juuxel]

The registry (of StatusEffects) is called mob_effect.

[liach]

Hmm, we have ItemStack vs Item, InfoEnchantment vs Enchantment, and StatusEffectInstance vs StatusEffect. They are all type + count combinations with some extra informations. Don't think simply renaming StatusEffectInstance to StatusEffect is helpful in this way.

[Juuxel]

StatusEffect vs StatusEffectType vs StatusEffectCategory would match Entity vs EntityType vs EntityCategory, as well as BlockEntity vs BlockEntityType.

Also, what sort of a name is InfoEnchantment 🤔

[liach]

InfoEnchantment is the enchantment type + level pair. maybe we can have InfoEnchantment -> Enchantment and Enchantment -> EnchantmentType

[Prospector]

Nah that doesn't make much sense imo. It would be more like an EnchantmentState probably. Still not big on that name though.

[liach]

Sure, I agree with juuz's rename proposal now.

[liach]

Note that EntityCategory is no more (now renamed to SpawnGroup), may need a better name for StatusEffectCategory

[Juuxel]

I think StatusEffectCategory still works for what it does. (we don't have to follow entity naming in status effects)

[liach]

Now looking at #2648, renaming the current enum for beneficial harmful and neutral to category is good. The other two renames though I still object to.

[haykam821]

Would StatusEffectEntry be a suitable name for the current StatusEffectInstance?