Alon Zakai
Alon Zakai
I can't seem to download that. Try uploading it in a zip (or tar.gz or such), that is the usual workaround for this github issue.
Thanks. It looks like this is hitting a limitation of the Flatten pass which runs in `-O4`. It does not yet handle arbitrary branching instructions like `BrOn`. Unfortunately it also...
> Ideally I think the code would avoid generating temp JS objects. Good point, +1 Let's avoid the object creation here.
By object creation, we mean the line with `const arrayClasses = { .. }`. That allocates a new object each time it is reached (maybe not each loop iteration if...
Sounds good to update, but looks like Alpine is failing on that revision? Maybe we should wait for a stable release?
Those sound like reasonable assumptions to me. But IIANM the order of copying matters when the ranges overlap, too: ``` [----------] [----------] ``` Copying the former over the latter in...
I don't follow, how would extending to i64 help here? Would we be able to check things we don't currently (what)?
I see. We can also test for that overflow in 32-bit (`x + y < x` implies overflow if both are unsigned), but I don't know what's simpler. I'm also...
> I'm running all the emscripten tests with the pass enabled (and I'm considering adding another test mode that builds for MVP wasm which would have them enabled continuously? WDYT...
You can call the logging imports, see https://github.com/WebAssembly/binaryen/blob/52cae1142bb8c06c98c4887ef9ffefff70dbeefc/test/lit/exec/fuzzing-api.wast#L25-L35 and their definitions earlier in that file.