Results 1275 comments of Alon Zakai

Unfortunately the issue is due to how JS parsing and toString works: ```js > x = (function a() { return { 'b': 5 } }) [Function: a] > x.toString() "function...

> ...meaning `.limits` is now `.nb`! If `.limits` arrives from the WebGPU API, then `device.limits` should be `device['limits']` in `library_webgpu.js`.

I'm not sure who packaged ammo on npm - I don't believe it was me. It might be best to reach out to the people listed as maintainers/collaborators there.

I see we have `test_cmake_threads` in `test/test_other.py`. That enables shared memory here: https://github.com/emscripten-core/emscripten/blob/ea35c8cde53d4691504436300493d60b49ff3744/test/cmake/threads/CMakeLists.txt#L5 Is that not enough to show the problem this PR fixes? (If not, can we add to...

Hmm, it looks like the pass assumes it can merge modules together: https://github.com/WebAssembly/binaryen/blob/c91c0520a617ce7b72315451645dba0792ea59f4/src/passes/MinifyImportsAndExports.cpp#L109-L110 That is possible in some cases, e.g. Emscripten, and I guess we never documented that on the...

I see. A flag to control the singleton module name also sounds ok to me to add, or to emit it to stdout - either way.

I believe this is valid, though I also vaguely remember there was a reason it might not always be helpful... @fgmccabe @tlively do you know what the best practices are...

Strange about that fuzzer error. You might need to debug that line `test_name = random.choice(all_tests)` to see why `all_tests` is empty (I assume the error means it is empty and...

> wasm-bindgen at compile time puts the information it needs to generate JS inside the .wasm file itself in the form of _describe functions. Does rustc then read the wasm...

Very cool! > I don't understand why sometimes log-i64 is imported with [different signatures] That is due to JS legalization. i64s are not legal in JS, at least before BigInt...