Alon Zakai
Alon Zakai
Test looks great! lgtm with the same for `memory.fill`.
This looks very interesting but I'm not sure if we can fix the oversaturating issue..? It seems like we'd need to live with it and hope for the best. Hard...
That's a nice speedup... given it's so large I feel it's worth the risk here. If we land this we can document it and suggest e.g. EMCC_CORES as a way...
Interesting idea. Do you have measurements on some benchmark perhaps? I'm not sure I have a good guess about this without data.
See discussion and workarounds on the rust side: * https://github.com/rustwasm/wasm-bindgen/issues/4211 * https://github.com/rust-lang/rust/issues/128475 Separately, it would be nice to support multiple tables in wasm2js, but those links might help people stuck...
Also see the failing test, an expectation needs to be updated. See instructions for that in the CI error.
Binaryen does have some limited DWARF support, but it focuses on reading and writing DWARF generated by LLVM (not generating new DWARF), and has known issues. Binaryen's source maps support...
@quanterion binaryen only tracks instruction locations for DWARF, not locals, so we disable passes that change locals. even for instructions, there are reports of the tracking not being perfect, and...
Linking to the corresponding PR: https://github.com/WebAssembly/binaryen/pull/7641
Loop handling fixed + tests, and other feedback should also be addressed now.