binaryen icon indicating copy to clipboard operation
binaryen copied to clipboard

Update mimalloc to v2.2.3

Open dschuff opened this issue 8 months ago • 2 comments

This brings in revision 4aae566191b9443d53995245b637ce28d617710a, needed to build on Windows.

dschuff avatar Apr 03 '25 16:04 dschuff

Sounds good to update, but looks like Alpine is failing on that revision? Maybe we should wait for a stable release?

kripken avatar Apr 03 '25 16:04 kripken

I had thought that this was a stable release (the 2.2.3 tag). The revision I pulled in was not actually the one I linked to, I just wanted to say why I was updating. I will double check (GH really does not make it easy to tell exactly what the old a new revisions are for submodules).

dschuff avatar Apr 03 '25 18:04 dschuff

The compilation failure on Alpine Linux ought to be fixed with commit https://github.com/microsoft/mimalloc/commit/341149391fee496790a7fa916b1fd3fdd0cce1a1, which is included in mimalloc v2.2.4 (https://github.com/microsoft/mimalloc/commit/fbd8b99c2b828428947d70fdc046bb55609be93e).

kleisauke avatar Jun 30 '25 10:06 kleisauke

Updated to 2.2.4. I don't think we necessarily need to have this (on emscripten-releases we've just updated the Linux build to use mimalloc because of a performance issue) but updating seems good in general.

dschuff avatar Jun 30 '25 20:06 dschuff