Results 1275 comments of Alon Zakai

I'm curious, why is deep nesting worse here (rust/ayzim vs c++/old optimizer)?

But the old optimizer will still recurse those nodes, not to free them, but to do all the other stuff it does? Why is freeing special here?

Oh right, thanks, I forgot we de-recursed traversal in C++. I had the earlier JS version in mind which is recursive.

Heh, thanks, maybe I'll wait then. I did run into a build error now (that I started on rust master, before reading this).

No luck with that revision. I'm trying ``` ./configure --llvm-root=/home/alon/Dev/fastcomp/build/Release+Asserts make ``` and it works for a while, then ``` rustc: x86_64-unknown-linux-gnu/stage0/lib/rustlib/x86_64-unknown-linux-gnu/lib/librbml compile: x86_64-unknown-linux-gnu/rustllvm/ExecutionEngineWrapper.o /home/alon/Dev/rust/src/rustllvm/ExecutionEngineWrapper.cpp: In function ‘LLVMOpaqueExecutionEngine* LLVMBuildExecutionEngine(LLVMModuleRef, LLVMRustJITMemoryManagerRef)’:...

Interesting stuff here! In general, I am hoping that we do a large rewrite of the emscripten FS code in the next few months (ASMFS, or related). So any large...

Oops, sorry @jlongster , I missed this in my inbox somehow... I like the idea to make the filesystem separate somehow. The closest thing I am aware of is BrowserFS...

You probably need a newer emscripten, that API was added fairly recently (for this polyfill, in fact).

Oh, sorry, my mistake. This is just in the `wasm-polyfill-prototype` branch in emscripten so far, which has not yet been merged to incoming or master.

That is what we do in web builds now - are you suggesting that we run the packer in JS as well, instead of natively (relying on deterministic ToNumber)? Sounds...