Alon Zakai comments

Results 1275 comments of


                                            Alon Zakai

Failed to install binaryen through Github API during a release

Thanks, yeah, that does seem odd. I didn't actually realize that github releases are not atomic... so it incrementally adds files as they go, it seems? Looks like it's all...

JSPI asynchronous calls into WASM are much slower than Asyncify

One thing to worry about here is on-stack replacement. If you call the function `time()` many times, do the results change? (Without OSR, the issue is that once inside a...

JSPI asynchronous calls into WASM are much slower than Asyncify

Thanks, yes, that's what I meant. Ok, I think that confirms that OSR is not a factor here, which is good to rule out.

JSPI asynchronous calls into WASM are much slower than Asyncify

@brendandahl do you know who would be good to cc on that chromium bug?

JSPI asynchronous calls into WASM are much slower than Asyncify

Interesting, thanks. Ok, I think we can cc them here actually: @thibaudmichaud @spy - last comment may already answer the question, but please confirm if you can, thanks!

Enabling Asyncify breaks module: Module.dynCall_i is not a function

Does removing `ASYNCIFY_ONLY` help?

Enabling Asyncify breaks module: Module.dynCall_i is not a function

I can confirm the problem with that small testcase. Something is wrong in that the wasm calls `invoke_i`, and the JS has that, which calls `dynCall_i` back into the wasm,...

Enabling SAFE_HEAP leads to wasm-validator errors

That looks like a serious and unknown bug, @cmourglia . Can you provide a testcase so we can investigate? I am afraid that error by itself isn't enough to know...

library_webgpu.js shim doesn't seem to support closure pass

Maybe add a little logging - is the value sent into `format` undefined somehow? If the read on the typed array is out of bounds, it would be, but it...

library_webgpu.js shim doesn't seem to support closure pass

Interesting... I tested various combinations here: ```js addToLibrary({ $libA: { PreferredFormat: { 'rgba8unorm': 0x12, 'bgra8unorm': 0x17, }, }, $libB: { 'rgba8unorm': 0x12, 'bgra8unorm': 0x17, }, $libC: function() { return {...