Alon Zakai
Alon Zakai
@osa1 If there is a use case then we should review and get this landed, I agree, but I don't think I understand the need there yet. The standard solution...
@mkustermann Two files does add some complexity, that is true. But in my experience on the Emscripten side that has not been much of an issue in practice. And as...
Fair enough, as I said, if you feel strongly then I don't object. I'll find time later today to review this in detail.
It looks like the code above your changes to `module-utils.cpp` was added in f44912bf23 (#6372), which includes tests. See specifically the test code in `test/lit/merge/sourcemap.wat*` for merging. I don't see...
If you want the Binaryen C API specifically then [rust-bindgen](https://github.com/rust-lang/rust-bindgen) should be able to automatically generate them, I think. See also https://github.com/brson/wasm-opt-rs , though I think that might be higher-level...
I just released version 124 now, https://github.com/WebAssembly/binaryen/releases/tag/version_124
Unfortunately the wat text format considers code like this equal: ```wat (struct.new $t (local.get 0)) (local.get 0) (struct.new $t) ``` So the parser has to accept it. Though if an...
@tlively you know that code best - any ideas?
I think this warning is sometimes helpful, so I'd lean towards finding a reasonable workaround in the code, or using a pragma.
Hmm, we do take the address of a local there, but it is safe as the call to `walk()` will fully consume the data with that address. So this looks...