Results 1275 comments of Alon Zakai

Looks like a problem with our DWARF support, which is experimental. It is recommended to use source maps instead for debugging. To avoid this problem you can strip debug info,...

@BilelGho This should be fairly easy, but would require changes in various places: * You would add the page size as a property on the Memory class in `wasm.h`, replacing...

Before getting into details here, please see this wiki page: https://github.com/WebAssembly/binaryen/wiki/Pruning-unneeded-code-in-wasm-files-with-wasm-metadce#example-pruning-exports `wasm-metadce` can prune exports, perhaps that is enough for your use case?

I see, thanks. I don't feel strongly, then, since it somewhat different. Maybe let's keep it open and see if other people comment that they could benefit as well -...

Thanks for the PR! I'm not sure where the best place to put this documentation is. We should perhaps point to `wasm-builder.h` or `wasm.cpp` as containing the implementations of the...

I don't believe there is a specific limit for such nesting. Here is the V8 file with such limits: https://github.com/v8/v8/blob/main/src/wasm/wasm-limits.h I don't recall this being an issue in the past,...

Another option would be to make such literals point to the Module the thing is in, and still refer to it by name.

This affects not only cross-module calls but also in a single module when there are duplicate tags: imagine we import the same tag from JS twice, once as wasm name...

What are your plans for using this in practice? I'm not aware of other toolchains doing so, so I'm curious.

I see, thanks for the update. In that case, I think I prefer not to merge this, if we can't test it against a known correct implementation, and don't have...