pkg

pkg copied to clipboard

## Expected Behavior Related to https://github.com/knative/eventing/issues/5574 When pulling this image, it is expected to see semver tags (or some other versioning) gcr.io/knative-releases/knative.dev/pkg/apiextensions/storageversion/cmd/migrate ## Actual Behavior There are no versions, only...

ac-miller

Optionally generate an init func for an informer

2

# Changes - Allows to kip the generation of the init func for an informer - Based on the suggestion here https://github.com/knative/pkg/pull/2976#issuecomment-1994401541 - Replacement for https://github.com/knative/pkg/pull/2976 - Tested locally and...

skonto

webhook: add options to disable resource_namespace tag in metrics

12

To add some context, historically, `resource_name` was removed from this tag list due to its high potential of causing high metrics cardinality. See [knative/pkg#1464][1] for more information. While that's great,...

zhouhaibing089

Extend secret reading for webhook certificates

4

[Webhook Certificates reconciler's logic](https://github.com/knative/pkg/blob/74ac82a333a43e5eabd3feb49311c6c680c29366/webhook/certificates/certificates.go#L63) will update secrets contents if the secret is expired or if the secret is empty. We start with an empty secret so the reconciler can generate...

skonto

Drop mako code and dependency

4

We removed the dependency to [mako](https://github.com/google/mako) from Serving in https://github.com/knative/serving/pull/14289. With this no longer used, the mako go depencendy and all the stub code here in `pkg` can be dropped....

ReToCode

RFC: Support dynamic reconfiguration of "buckets"

5

/area API /kind feature I mentioned this in slack, but given that we already support being promoted to and demoted from "leader" dynamically, could we support dynamically changing the bucket...

mattmoor

Migrate to new K8s generator scripts/go commands

2

## Context See https://cloud-native.slack.com/archives/C04LGHDR9K7/p1704710449414709 and https://github.com/knative/pkg/pull/2904 ## Possible solutions Based on https://github.com/knative/pkg/pull/2904#issuecomment-1851613905 and discussions. a) Use `go run` instead of scripts (downside: this does not clean up old resources) b)...

ReToCode

Drop and turn off QPS and Burst setting

5

/area API /kind cleanup Please refer to https://github.com/knative/pkg/pull/2755#issuecomment-1593590298 Upstream recommends that we should turn off it and use APF instead.

nak3

Consider putting the admission review on the webhook context

13

> The use case is that I need to parse again the AdmissionRequest from Request.Body to perform further checks in the validating/mutating phase. Would it make more sense for the...

dprotaso

webhook: register metrics only with default stats reporter

5

This is a followup from [knative/pkg#2931][1]. RegisterMetrics may register unwanted metrics if the default stats reporter is not used. [1]: https://github.com/knative/pkg/pull/2931 /kind cleanup ```release-note None ```

zhouhaibing089