pkg
pkg copied to clipboard
knative
Knative common packages
At the moment knative only supports tracing to Zipkin backends. It would be good to have more options, e.g. supporting Jaeger tracing backends as well (natively, without the need of...
Hoping to get some insight on the following issue. Happy to hop on a call or slack huddle in the knative slack to give more info. ## Expected Behavior The...
OpenCensus & OpenTracing have merged to form OpenTelemetry (see https://github.com/census-instrumentation/opencensus-go & https://medium.com/opentracing/a-roadmap-to-convergence-b074e5815289). Knative should to move to instrumenting metrics and traces with OpenTelemetry instead of OpenCensus ahead of OpenCensus getting...
Signed-off-by: Ville Aikas # Changes Currently when we create the validatingwebhookconfiguration, there's couple of wonky things with it: 1. Always includes status as a subresource and there are cases where...
/kind bug ## Expected Behavior The admission controller to reply to k8s API server on failed admission requests with http code != 2XX. ## Actual Behavior Even when the request...
https://github.com/knative/pkg/blob/1ad02a5662d29355fbd23d13cce08b2677ece901/kmeta/names.go#L60 Sometimes resource generation does not work without validation of `.` as well as `-`. It may be a good idea to modify the terminating character if it is not...
the default continues to include the prefix Part of: https://github.com/knative/pkg/issues/2174
ie. serving doesn't have validation logic for the `status` block since we expect only our controllers update it. But our webhooks are invoked for status updates https://github.com/knative/pkg/blob/132b1e71088b721a05f447b18e4459ffe8828169/webhook/resourcesemantics/defaulting/defaulting.go#L148-L152
/area API /area networking /area test-and-release /kind bug /kind good-first-issue ## Expected Behavior A `TableTest` with `WantDeleteCollections` verifies things work! ## Actual Behavior It silently ignores `DeleteCollection` calls. See also:...
``` === RUN TestAdmissionInvalidResponseForResource [2366](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_pkg/2425/pull-knative-pkg-unit-tests/1493620921280237568#1:build-log.txt%3A2366) logger.go:130: 2022-02-15T16:23:56.397Z INFO webhook/webhook.go:200 Informers have been synced, unblocking admission webhooks. [2367](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_pkg/2425/pull-knative-pkg-unit-tests/1493620921280237568#1:build-log.txt%3A2367) 2022/02/15 16:23:56 http: TLS handshake error from 127.0.0.1:50900: EOF [2368](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_pkg/2425/pull-knative-pkg-unit-tests/1493620921280237568#1:build-log.txt%3A2368) logger.go:130: 2022-02-15T16:23:56.551Z ERROR...