pkg

pkg copied to clipboard

Rewrite the Knative code-gen to a Go-native tool

5

## Expected Behavior To fix https://github.com/knative/infra/issues/134 we need to remove the shell wrapper, so the Knative projects could run the code-gen in `go run ...` native way. ## Actual Behavior...

cardil

## Expected Behavior  ## Actual Behavior  ## Steps to Reproduce the Problem 1. 2. 3. ## Additional Info

wenbinyang

[wip] Webhook OTel changes

3

This stacks onto the shared main PR - https://github.com/knative/pkg/pull/3190 You can review the webhook changes here - **webhook changes for observability** - **go mod** - **vendor**

dprotaso

Consider changing sharedmain behaviour about panic'ing when a config map is missing

1

That's fine. I'm slighly worried about "halt and catch fire" as a behavior when a configmap we ship has been removed. The idea of shipping them has mostly been about...

dprotaso

We want to bump OTel-go contrib at the end of the month to get the right go metrics This would pull in this PR https://github.com/open-telemetry/opentelemetry-go-contrib/pull/7418

dprotaso

Support customizing controller's StatsReporter through injection-gen

4

admission webhook supports to customize StatsReporter via context: https://github.com/knative/pkg/blob/a877090f011ffdff7227c436d9553d7ca4699bc1/webhook/context.go#L25-L39 But controller constructor (NewImpl) which generated via injection-gen doesn't: https://github.com/knative/pkg/blob/a877090f011ffdff7227c436d9553d7ca4699bc1/codegen/cmd/injection-gen/generators/reconciler/reconciler_controller.go#L277 it would be helpful to allow customizing this one.

jeongukjae

Add a flag in tracing config to use service instead of pod name

5

### Add a flag in tracing config to use service instead of pod name While the OTel migration is in progress it would be very helpful to have a flag...

pomyslowynick

Fix panic on DeletedFinalStateUnknown in ConfigMap informer

9

Fixes #3220

anjalii-28

Add TLSMaxVersion, TLSCipherSuites, and TLSCurvePreferences to webhook.Options for minimal tls customization

9

This change adds minimal TLS configuration API for webhooks Add TLSMaxVersion, TLSCipherSuites, and TLSCurvePreferences fields to webhook.Options for granular TLS control without exposing full tls.Config. - TLSMaxVersion: enforce Modern profile...

jkhelil

Figure out how to support more OTel knobs

9

TIL: there's an _almost_ stable config that will work across OTel implementation here: go implementation https://pkg.go.dev/go.opentelemetry.io/contrib/otelconf/v0.3.0 spec: https://github.com/open-telemetry/opentelemetry-specification/issues/4374 We could support additional OTel knobs by allowing operators to specify such...

dprotaso