pkg icon indicating copy to clipboard operation
pkg copied to clipboard

Drop mako code and dependency

Open ReToCode opened this issue 2 years ago • 4 comments

We removed the dependency to mako from Serving in https://github.com/knative/serving/pull/14289.

With this no longer used, the mako go depencendy and all the stub code here in pkg can be dropped.

Work needed

  • Check for usage of mako in all knative and knative-extensions repositories prior to deleting it here
  • Drop mako golang dependency
  • Drop code at "knative.dev/pkg/test/mako/stub-sidecar"
  • Find other references (if any) and drop them as well

ReToCode avatar Sep 14 '23 05:09 ReToCode

Eventing still has a dependency on the mako-stub. So this task is on hold, until this dependency is removed.

ReToCode avatar Sep 14 '23 07:09 ReToCode

cc @pierDipi do you plan on continuing using this stub?

dprotaso avatar Sep 14 '23 13:09 dprotaso

I'm not aware of anybody using the performance tests in Eventing, I believe we can remove them and with that the mako usage

pierDipi avatar Feb 20 '24 16:02 pierDipi

https://github.com/knative/eventing/pull/7707

pierDipi avatar Feb 20 '24 16:02 pierDipi

@Zerpet @ikavgo @mkuratczyk eventing-rabbitmq is using the mako-stub for performance tests, do you still need the mako stub or are you migrating off of it?

pierDipi avatar Apr 03 '24 14:04 pierDipi