pkg
pkg copied to clipboard
knative
Knative common packages
This change introduces a `targeter.Interface` abstraction that we've been using downstream to abstract the core logic of webhooks from the details of how delivery to them is handled. The most...
On leader promotion, the controller will enqueue all known instances of `Kind` without filtering on the provided `classValue`. ```go LeaderAwareFuncs: reconciler.LeaderAwareFuncs{ PromoteFunc: func(bkt reconciler.Bucket, enq func(reconciler.Bucket, types.NamespacedName)) error { all,...
/kind bug (I'm fine if we want to consider this a feature request, but to me it rather seems like this was overlooked in https://github.com/knative/pkg/pull/626) ## Expected Behavior [`duck.TypedInformerFactory`](https://github.com/knative/pkg/blob/f907b31046d3c69a29b13d6d6ad2907767faac1e/apis/duck/typed.go#L36-L43) honors...
/area networking Follow up from Serving PR: https://github.com/knative/serving/pull/12033 - comment about KProbe logic in drainer being a duplicate functionality https://github.com/knative/serving/pull/12033#pullrequestreview-779938231 ``` A related concern (but I don't think it should...
/area monitoring /kind question ## Expected Behavior Consider logging validation errors at a lower level (`info`) to signal that the webhook is working as expected. ## Actual Behavior The AdmissionController.Admit...
/area monitoring /kind cleanup We currently prepend a 'domain' and the 'component' name to the metrics. This done for our OpenCensus exporter which might have been cargo cult'd from our...
**Problem** As stated on the [Cloud Events Spec](https://github.com/cloudevents/spec/blob/v1.0.1/spec.md#attribute-naming-convention) the attribute naming convention suggest (SHOULD, not MUST) that the names are no longer than 20 characters. We should add at maybe...
When deploying a webhook, it may be desirable to _not_ make use of the `certificates` controller (for generating a TLS certificate for the webhook), nor reading the TLS data _from_...
## Expected Behavior Tekton has created a new custom resource called Run for running custom tasks. Each custom task implementer will provide a reconciler that watches for and processes Run...
Refs: https://kubernetes.io/docs/reference/using-api/server-side-apply/ https://github.com/knative-sandbox/net-contour/issues/347#issuecomment-838613107 This would allow customization of the resources we create /assign @dprotaso