pkg icon indicating copy to clipboard operation
pkg copied to clipboard

Drop and turn off QPS and Burst setting

Open nak3 opened this issue 2 years ago • 5 comments

/area API /kind cleanup

Please refer to https://github.com/knative/pkg/pull/2755#issuecomment-1593590298

Upstream recommends that we should turn off it and use APF instead.

nak3 avatar Jun 16 '23 00:06 nak3

If we do this, I'd advise to coordinate with working groups if we plan to make breaking changes in this area, it seems we're suggesting to turn them off but that is only a partial solution.

I would actually suggest to allow turning them off but as opt-out config

pierDipi avatar Jun 16 '23 07:06 pierDipi

I got an advice from internal team that disabling client-side rate-limiting is a GA goal of APF.

https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/1040-priority-and-fairness/README.md#graduation-criteria

APF allows us to disable client-side rate limiting without causing the apiservers to wedge/crash.

And there are still some efforts like https://github.com/kubernetes/kubernetes/pull/109614

So yes, we should take care this carefully or actually we can just wait for GA of APF.

nak3 avatar Jun 16 '23 07:06 nak3

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Sep 15 '23 01:09 github-actions[bot]

/lifecycle frozen

dprotaso avatar Sep 15 '23 13:09 dprotaso

We should revisit this once our serving perf changes lands

dprotaso avatar Sep 15 '23 13:09 dprotaso