pkg icon indicating copy to clipboard operation
pkg copied to clipboard

Migrate to new K8s generator scripts/go commands

Open ReToCode opened this issue 1 year ago • 2 comments

Context

See https://cloud-native.slack.com/archives/C04LGHDR9K7/p1704710449414709 and https://github.com/knative/pkg/pull/2904

Possible solutions

Based on https://github.com/knative/pkg/pull/2904#issuecomment-1851613905 and discussions.

a) Use go run instead of scripts (downside: this does not clean up old resources) b) Use the new k8s.io/code-generator/kube_codegen.sh c) Wait until @cardil manages to migrate the scripts in K8s to full golang, then adapt to that solution

Todo

  • [ ] Agree on which way to go
  • [ ] Implement in pkg
  • [ ] Implement on all downstream repos

ReToCode avatar Jan 08 '24 12:01 ReToCode

From the discussion in https://github.com/kubernetes/kubernetes/pull/122236 it is best to wait a bit until Kubernetes figures out the new way. Until then, https://github.com/knative/hack/pull/357 will help to minimize the work needed for now.

ReToCode avatar Jan 09 '24 08:01 ReToCode

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Apr 09 '24 01:04 github-actions[bot]