killianmuldoon

Results 44 issues of killianmuldoon

When Cluster API is backed up and restored the ownerReferences on the Kubernetes Secrets relating to the cluster are not restored. This doesn't seem to cause issues in the functioning...

kind/cleanup
area/ux

When Cluster API is backed up and restored the ownerReferences on the KubeadmConfig are not restored. As there is a check in the KubeadmConfig reconciler for the ownerReference [these KubeadmConfigs...

kind/bug
kind/cleanup
area/bootstrap

Currently the only way to generate our release manifests with the CAPI Makefile is to run `make release`. Currently this runs the following targets: ```Makefile GIT_VERSION=$(RELEASE_TAG) $(MAKE) release-binaries # Set...

kind/cleanup
triage/accepted

Signed-off-by: killianmuldoon Fix an issue introduced in https://github.com/kubernetes-sigs/cluster-api/pull/6973 to properly generate CAPD manifests during the nightly release process.

cncf-cla: yes
size/XS
needs-triage

Following on from https://github.com/kubernetes-sigs/cluster-api/issues/5240 we should probably add ObjectMeta to all of our *TemplateResource types as we did for the Docker infrastructure templates in https://github.com/kubernetes-sigs/cluster-api/pull/5441 There's no clear use case...

kind/cleanup
area/control-plane
area/bootstrap
triage/accepted

Signed-off-by: killianmuldoon Add a `.gitattributes` file to hide generated CRD yamls in PRs. Our generated go code is already automatically hidden by [github linguist](https://docs.github.com/en/repositories/working-with-files/managing-files/customizing-how-changed-files-appear-on-github). The `.gitattributes` file lets us customize...

cncf-cla: yes
lgtm
size/XS
needs-triage

Signed-off-by: killianmuldoon Ensure we always remove the name of the reconciled object from the resulting error message. The current function works for MachineTemplates, but not for e.g. KubeadmControl plane and...

size/S
cncf-cla: yes
lgtm
needs-triage

Signed-off-by: killianmuldoon This changes adds setting nodeDrainTimout field to the ControlPlane and MachineDeploymentTopology in our ClusterClass quick start test and adds a fix which unquotes the string before setting it...

size/S
cncf-cla: yes
lgtm
needs-triage

Currently validation for our APIs is done, for the most part, in our webhooks. OpenAPI validation could be added (possibly using kubebuilder tags) to make this validation part of our...

kind/feature
kind/api-change
area/api

Signed-off-by: killianmuldoon Add some example queries to show how to use json logging and the Tilt logging suite to filter and correlate logs across Cluster API providers.

cncf-cla: yes
lgtm
size/M
needs-triage