cluster-api
cluster-api copied to clipboard
kubernetes-sigs
🐛 Strip control plane creation error of unique name
Signed-off-by: killianmuldoon [email protected]
Ensure we always remove the name of the reconciled object from the resulting error message. The current function works for MachineTemplates, but not for e.g. KubeadmControl plane and can result in infinite reconciles as a result. This is related to the change made in https://github.com/kubernetes-sigs/cluster-api/pull/5971 and solves the same issue, but for a wider range of objects and error messages.
@killianmuldoon: This issue is currently awaiting triage.
If CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you.
In response to this:
Nice catch!
/cherry-pick release-1.2
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: sbueringer
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [sbueringer]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@sbueringer: new pull request created: #7124
In response to this:
Nice catch!
/cherry-pick release-1.2
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.