cluster-api icon indicating copy to clipboard operation
cluster-api copied to clipboard

Added ObjectMeta to KubeadmConfigTemplateResource, KubeadmControlPlaneTemplateResource

Open killianmuldoon opened this issue 2 years ago • 2 comments

Following on from https://github.com/kubernetes-sigs/cluster-api/issues/5240 we should probably add ObjectMeta to all of our *TemplateResource types as we did for the Docker infrastructure templates in https://github.com/kubernetes-sigs/cluster-api/pull/5441

There's no clear use case for adding this meta to KubeadmConfigTemplateResource, KubeadmControlPlaneTemplateResource, but there seems to be consensus that this field should be added for consistency.

Related: https://github.com/kubernetes-sigs/cluster-api/issues/5393, https://github.com/kubernetes-sigs/cluster-api/pull/5371

/kind cleanup /area bootstrap /area control-plane

killianmuldoon avatar Jul 25 '22 10:07 killianmuldoon

Should we then re-add it also to the documentation as part of this issue? (has been dropped here if I'm not mixing up things)

sbueringer avatar Aug 16 '22 10:08 sbueringer

/triage accepted

fabriziopandini avatar Sep 30 '22 20:09 fabriziopandini

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Dec 29 '22 20:12 k8s-triage-robot

/kind api-change /lifecycle frozen

fabriziopandini avatar Dec 30 '22 12:12 fabriziopandini

Done in #8180

/close

sbueringer avatar Mar 15 '23 08:03 sbueringer

@sbueringer: Closing this issue.

In response to this:

Done in #8180

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 15 '23 08:03 k8s-ci-robot