cluster-api
cluster-api copied to clipboard
kubernetes-sigs
🐛 Fix omitted target in CAPD staging Makefile target
Signed-off-by: killianmuldoon [email protected]
Fix an issue introduced in https://github.com/kubernetes-sigs/cluster-api/pull/6973 to properly generate CAPD manifests during the nightly release process.
@killianmuldoon: This issue is currently awaiting triage.
If CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Double checked it now. I think everything should work as expected now.
/cherry-pick release-1.2
/lgtm /approve
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you.
In response to this:
Double checked it now. I think everything should work as expected now.
/cherry-pick release-1.2
/lgtm /approve
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: sbueringer
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [sbueringer]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@sbueringer: new pull request created: #7069
In response to this:
Double checked it now. I think everything should work as expected now.
/cherry-pick release-1.2
/lgtm /approve
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.