cluster-api
cluster-api copied to clipboard
kubernetes-sigs
🐛 Fix nodeDrainTimeout for ControlPlane on Topology managed clusters
Signed-off-by: killianmuldoon [email protected]
This changes adds setting nodeDrainTimout field to the ControlPlane and MachineDeploymentTopology in our ClusterClass quick start test and adds a fix which unquotes the string before setting it in the patch.
On reviewing #https://github.com/kubernetes-sigs/cluster-api/pull/7031 it looks like we're not able to reconcile NodeDrainTimeout (added in https://github.com/kubernetes-sigs/cluster-api/issues/6278) on the control plane in a topology managed cluster.
@killianmuldoon: This issue is currently awaiting triage.
If CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@abhijit-dev82 this is where I'm figuring out a fix for https://github.com/kubernetes-sigs/cluster-api/pull/7031
Failed run before fix here: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/7047/pull-cluster-api-e2e-informing-main/1557400014039289856
We should probably cherry pick this to 1.2 give it's a broken feature that was including in that release.
/cherry-pick release-1.2
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you.
In response to this:
We should probably cherry pick this to 1.2 give it's a broken feature that was including in that release.
/cherry-pick release-1.2
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Thx!
/lgtm /approve
Agree with the cherry-pick.
(cc @fabriziopandini just fyi, setting the nodeDrainTimeout on cp will only work in the upcoming v1.2.x release)
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: sbueringer
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [sbueringer]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@killianmuldoon: new pull request created: #7072
In response to this:
We should probably cherry pick this to 1.2 give it's a broken feature that was including in that release.
/cherry-pick release-1.2
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.