Justin McCandless

Results 206 comments of Justin McCandless

Ah that's why. Alright I'll plan to try it again once you update the engine PR. Let me know if you need me to post any more logs or anything...

@LongCatIsLooong Are you still planning to merge this? Sorry I never gave a final review. Looks like it needs to be merged with master now.

CC @matthew-carroll, you were talking about alternative architectures for InteractiveViewer. Any thoughts on how this could be done without bloating the parameter list? This is more evidence in support of...

@matthew-carroll That sounds like more reasons for InteractiveViewer to be broken into composable widgets. It seems like you just want part of its functionality. You could use a raw Transform...

@tgucio Checking in on this, do you still have plans to come back to this PR?

I tried rerunning the Google tests locally and there are indeed some failures. I think there's some slight changes to text layout. In one case I see some text has...