Justin McCandless
Justin McCandless
Thanks everyone for pointing this out! I forgot that I can make these examples work on web now. I'll fix them by using `disableContextMenu` and also add some links so...
Confirmed that the examples in the master docs seem to work on web now. https://master-api.flutter.dev/flutter/widgets/EditableText/contextMenuBuilder.html
How do we expect this to work with the [expands](https://master-api.flutter.dev/flutter/material/TextField/expands.html) parameter too? I think there might be some kind of conflict between the `expands` parameter and the Expanded widget, like...
@guidezpl Thank you, I was hoping a better name would come to me! I'll change it to TextLink.
@guidezpl I went back and forth but I've currently got it named `LinkedText`. There is an inline version called `InlineLinkedText`. I'm still up for suggestions and might still change things...
I've filed an issue about the width of TextSpans with `recognizer`s that I discovered in this PR: https://github.com/flutter/flutter/issues/131435
Question for reviewers: By default, this uses a regex for matching URLs (devs are also open to use their own). The regex is pretty robust, but I could instead be...
### Major changes since last time * `InlineLinkedText` is removed publicly and merged with `LinkedText`. Users don't have to manage disposing `recognizers` any more. * The tree walking algorithm is...
### RegExp constructor I've moved it to TextLinkers as suggested. It's a little more verbose now, but you're right that it does feel like it should be on TextLinkers. Before:...
Here's my summary of this round of changes. Thanks for all of the code review! ### Recognizer ownership I've simplified this so that recognizer management is either totally handled internally...