Justin McCandless

Results 206 comments of Justin McCandless

From @chunhtai's suggestion above (https://github.com/flutter/flutter/pull/125927#discussion_r1317596181), I've made the default `LinkedText` constructor work only with Uris, so I can do the Uri parsing automatically. Then I brought back the `.regExp` constructor...

I don't think anything actually failed in the Google tests, but I've rerun them just in case.

This works on web just like any other platform, unless I'm missing something. Is the concern with the need to use url_launcher? ![output](https://github.com/flutter/flutter/assets/389558/d9366d8d-1ad3-4851-ba1c-fa2eac4511f0) Using LinkedText like this: ```dart import 'package:url_launcher/url_launcher.dart';...

Yes, but no link options like "Open link in new tab". Do you know if we have a way to do that on the web now? Maybe this is a...

Ah I see ([Link docs](https://pub.dev/documentation/url_launcher/latest/link/Link-class.html)). LinkedText does seem to work with Link on web and the other platforms (example below), but I would have to rethink this as part of...

@piedcipher Do you still have plans to come back to this PR? Need help with anything?

@piedcipher I see you pushed some commits here, let me know if/when you need a re-review. No rush.

@chunhtai Do you think this is working as intended based on your understanding of Flutter navigation?

Got it, thanks. Does anyone object to closing this issue as a "won't fix"? Or is there any docs change we can make or anything to help people avoid this...

Confirmed that on native iOS, the behavior is as expected, so this is a bug. CC @LongCatIsLooong from triage.