Justin McCandless
Justin McCandless
@tgucio Can you give the final approval here?
Looks like the same root cause to me. @exaby73 wasn't able to reproduce it over there, so it's good that @huycozy was able to here.
@cbracken I think the correct solution here is again to sync TextInputConfiguration with the engine, would you agree? I remember a very similar thing came up with obscureText. We said...
That's probably because the engine isn't set up to update keyboardType when updateConfig is called. The PR I mentioned above also needed an engine PR (https://github.com/flutter/engine/pull/40216) to allow it to...
Hmm it's not showing up in the Google testing tool for me. Can you try pushing a merge commit with master?
The Google test failures were all to be expected - they should be accepted with the updated cursor color. I've set them to show a pass here. The framework test...
Alright let's see if my rerun happens to fix anything, otherwise I'll ask about this test on Discord.
Looks like it passed, maybe a flake.
Thanks for the secondary review! I'll plan to merge this tomorrow morning.
@hasnentai Should the handle also be red instead of blue? I made an issue to track this (https://github.com/flutter/flutter/issues/122538) but I couldn't find a spec or anything that showed it being...