Justin McCandless
Justin McCandless
@MindMayhem Start with [this page](https://github.com/flutter/flutter/wiki/Running-and-writing-tests) in the wiki, and then take a look at the existing tests in in [snack_bar_test.dart](https://github.com/flutter/flutter/blob/master/packages/flutter/test/material/snack_bar_test.dart).
I've closed the PR that was attempting to address this for now. I think we require some more work to match the Material spec. See https://github.com/flutter/flutter/pull/115510#pullrequestreview-1209096861.
This is being tracked as a part of https://github.com/flutter/flutter/issues/35026, but I'll keep this issue open for specifics. I'm going to work on implementing this soon! It's good to see that...
This was brought up in https://github.com/flutter/flutter/issues/42894 under the name Modal Presentation. Also note that this is an iOS 13 feature.
I wanted to get this out, but unfortunately I can't work on this in the foreseeable future due to other priorities. If anyone else wants to take a crack at...
That's good to hear that there is a pub package, hopefully that will help a lot of people out. I looked into implementing it by modifying `CupertinoPageRoute`, but I never...
The package looks great. We might want to de-duplicate some code around the styling of the menu items here and in CupertinoContextMenu (see the gifs in https://github.com/flutter/flutter/pull/37778). CC @xster for...
@matthew-carroll It looks like this comes from a PR of yours a little over a year ago: https://github.com/flutter/flutter/pull/18381 Do you happen to remember why you calculated thickness in this way?...
Here's my investigation of this on master with a few devices lying around. "Original" has no change, and "No devicePixelRatio" has the single change mentioned above, so this line: https://github.com/flutter/flutter/blob/0120c414fbc5d11c503e2091f420c02ffd6dda67/packages/flutter/lib/src/cupertino/dialog.dart#L361...
Just putting this on your radar @MitchellGoodwin in case you haven't seen it before.