Justin McCandless

Results 206 comments of Justin McCandless

Google tests look fine despite the stuck "pending" status. I tried to change the status but it is giving an HTTP error. Merging.

@luckysmg Thanks for all your work here!

+1 to a stacktrace. The output of `flutter run -v` in https://github.com/flutter/flutter/issues/95496#issuecomment-998692986 doesn't seem to give any information about the error at all. However, if this was a simple index...

This should be fixed in https://github.com/flutter/flutter/pull/143249. Notice how the code has changed since this bug was filed and we now set the alignment based on the TextDirection: https://github.com/flutter/flutter/blob/aff5477dadb02a23df1129fbb47397fb452cfbe2/packages/flutter/lib/src/material/autocomplete.dart#L185-L188 But there's...

Just some quick research: On web, the behavior for `` is to select all on focus. For ``, the behavior is to remember the previous selection, or to put the...

No I don't think there is any way to tell why focus changed just from FocusNode. I agree with the `maxLines == 1` thing. We have debated having a TextArea...

Sounds good, I'm happy to review that when it's ready.

I agree, I think fundamentally we need to distinguish between on one hand causes of focus change that the field handles and then calls requestFocus on itself (e.g. tap), and...

I got carried away looking into solution 3 and wrote a quick PR. Does something like this work? https://github.com/flutter/flutter/pull/119583

This is not intended behavior. I'll mark it as a regression. I was able to reproduce it with the following code (though it looks cut off instead of totally disappearing):...