Justin McCandless
Justin McCandless
@vongrad Your fix looks like it could work, are you up for opening a PR? I want to see if it still passes all of our tests if you make...
Awesome! Please tag me in it when you do, I'm happy to review.
I'm not sure that this issue is still happening. I think _scheduleShowCaretOnScreen checks whether the selection is valid, so it shouldn't scroll in that case?
* When [the test](https://github.com/flutter/flutter/blob/81b0e9f1113c390f9e0b09d0eea1b4c13029c615/packages/flutter/test/material/text_form_field_test.dart#L107) is run with testWidgetsWithLinkTracking, then the EditableTextState (and the whole widget tree in pumpWidget?) is never disposed at the end of the test. If I change...
CC @LongCatIsLooong
CC @LongCatIsLooong
Sorry @luckysmg I missed your review request. Can you fix the merge conflicts here?
It looks like the customer tests are failing because there is a breaking change from adding startLiveTextInput to TextInputClient. Is there any reasonable way around making a breaking change there?...
@luckysmg How's it going with this, anything else I can help with? Looks like you have a conflict and need to push a merge commit.
Sounds good, keep us posted.