Justin McCandless

Results 206 comments of Justin McCandless

I did some investigation on the default transition when pressing the back button. I think we're fine leaving it as the default ZoomPageTransitionBuilder for now. On native, it seems to...

I pushed some simplifications. I'm trying to reduce the public API surface to make this PR a smaller first step, and then later think about what to expose to users....

Thanks for flagging that, I'll try out how it affects this PR. I've noticed the same problem with notifying in registration order. There are several places in the codebase that...

@maRci002 Maybe you're right about the controller. If any reviewers have an opinion please let me know. I'm taking a closer look at the organization of that. Thanks for the...

@goderbauer @LongCatIsLooong I've changed the event handlers in WidgetsBinding to save the observer that handled a `start` and send all events for the same gesture to the same observer: https://github.com/flutter/flutter/pull/141373/commits/ac0b088ee463ad197d5dcbc3012fb07f32b680a6...

PR https://github.com/flutter/flutter/pull/137792 might cover this, though it doesn't seem to fix it in its current state. I'm taking a look at landing that and will update this issue with the...

Noting that this does seem to be a problem with go_router itself and not the framework. If I use a version of the framework before PopScope was landed (f68d03f1cdf16dcffe2a53ae645ec87094e85d40^) and...

@chunhtai Did you reproduce this without go_router, or is the code sample in the issue description still the best way to reproduce this?

@chunhtai Did you reproduce this without go_router, or is the code sample in the issue description still the best way to reproduce this?

I tried to reproduce this on 17.0 and 17.4 simulators, and I could only see it on 17.4, interestingly. CC @LongCatIsLooong (who's currently on vacation for a month)