Justin Davis
Justin Davis
I took a moment to annotate these two bfbs files and have attached the outputs. it seems that windows is possibly doing a better job of vtable consolidation? I haven't...
It seems the original has more fields present
Linux encodes the 'deprecated' field, windows does not. ``` table (reflection.Field): +0x04E4 | 18 00 00 00 | SOffset32 | 0x00000018 (24) Loc: 0x04CC | offset to vtable +0x04E8 |...
confirmed on linux and windows that I get a matching file, containing the builtin attribute, with `./build/flatc -b --schema --bfbs-comments --bfbs-builtins samples/monster.fbs` -- which is the list of options present...
@relativityspace-jsmith I think I've found (part of) your issue -- in your PR you generate monster.bfbs in cmake here ``` flatbuffers_generate_headers(TARGET flatsample SCHEMAS samples/monster.fbs BINARY_SCHEMAS_DIR samples/ FLAGS ${FLATC_OPT_COMP}) ``` however,...
I think you may run into an actual "real" discrimination between the two -- windows and linux paths are added to comments differently.
hey @zct - this pr looks great and I would love to merge it. I will need you to complete the Contributor License Agreement to do so!
hey @kendegemaro! Yes, feel free to just modify the changelog -- you will need to sign a contributor license agreement, but will get instructions on how to do so when...
I reopened this, but it may actually be fixed by #8792 (by switching the name the other way)
@souma987 would love your input here