Justin Davis

Results 81 comments of Justin Davis

I believe the issue is that the installer for the latest release is named `VSCodePortable_Latest.paf.exe` instead of `VSCodePortable_online.paf.exe`

This seems worse to me as a solution, because you still need to double click to navigate to that section, and I prefer single click in the other explorer tabs...

these both fail with some flavor of ``` verifier.h:216:64: error: cannot convert 'flatbuffers::VerifierTemplate' to 'flatbuffers::Verifier&' {aka 'flatbuffers::VerifierTemplate&'} ```

Sure, I can certainly take a look.

Found a small bug when the payload doesn't start at the beginning of the buffer, and another small issue with parse_struct. Additionally, loading is a little weird on Wireshark <...

Currently tracking a limitation where you can only have one dissector present in the plugins directory at a time. Wireshark doesn't like you sharing common ProtoFields apparently.

hey @dbaileychess or @aardappel -- would either of you be willing to provide some insight on the open questions on my PR? :) I would really appreciate the feedback as...

@aardappel thank you for the thorough response! > I think that is a high cost decision, both in terms of having a lot of duplicated/unshared code with the main Lua...

I would love to see a regression test for this but happy to merge as is

@Homeblest looks like just the `if` -> `it` needs fixed now, if you rebase this guy I'll get it merged.