flatbuffers icon indicating copy to clipboard operation
flatbuffers copied to clipboard

[Python] Fix function name for Pack method for structs

Open kojung opened this issue 1 year ago • 1 comments

This PR fixes #8422 .

Before we get this:

class ABCWordT(object):
    # ABCWordT
    def Pack(self, builder):
        return CreateAbcword(builder, self.w)

Where the function CreateAbcword does not exist.

After we get this:

class ABCWordT(object):
    # ABCWordT
    def Pack(self, builder):
        return CreateABCWord(builder, self.w)

And the function CreateABCWord does exist.

kojung avatar Oct 13 '24 06:10 kojung

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Oct 13 '24 06:10 google-cla[bot]

This pull request is stale because it has been open 6 months with no activity. Please comment or label not-stale, or this will be closed in 14 days.

github-actions[bot] avatar Apr 13 '25 20:04 github-actions[bot]

This pull request was automatically closed due to no activity for 6 months plus the 14 day notice period.

github-actions[bot] avatar Apr 27 '25 20:04 github-actions[bot]

I reopened this, but it may actually be fixed by #8792 (by switching the name the other way)

jtdavis777 avatar Dec 14 '25 02:12 jtdavis777