Justin Davis comments

Results 81 comments of


                                            Justin Davis

[Python] Invalid generated code for packing structs with array of struct fields

I spent a few minutes poking around at this and think I understand what's going on. The `Pack` function generator does a good job of drilling down through structs looking...

[Python] Invalid generated code for packing structs with array of struct fields

I think some sort of wrapper `View` class which implements array index operators could also work, but may be more convoluted than it's worth.

Fix bfbs Lua/Nim generators: honor -o and create namespace dirs

@beingbrijesh just a friendly note - if you update your description with "fixes #8762" it will link this PR and that issue :)

[C#] Broken publish to NuGet

possibly related: #8730 @dbaileychess

Migrate C-style buffers to C++ containers

technically a duplicate of #8491 but will leave open for now.

fix(rust: builder): add lifetime bounds to finish methods

this seems good to me (as a rust n00b) -- is there a way we can write a regression test against this as part of this PR?

[TS codegen] Escape JSDoc terminator in doc comments to prevent comment closure and import‑time code execution

hey @Ky0toFu - thank you for a very comprehensive issue form! Are you interested in opening a PR for this issue? I'll defer to others (@bjornharrtell) on preference between your...

[TS codegen] Escape JSDoc terminator in doc comments to prevent comment closure and import‑time code execution

🥳

[Python] Improve python API

@satur9nine I've got this on my list! Will look it over sometime in the next few days 🤞

[Python] Improve python API

@fliiiix this seems like a good improvement but as always I enjoy an extra opinion :D