Justin Davis
Justin Davis
I am concerned this would be a breaking change -- if there is other code that depends on the lower case output to json, this would cause issues. Similarly, currently...
@aardappel probably could use your opinion on this one.
hey @jdemeyer - could you please fill out the PR description section for this? It would help others (especially those not versed in go ;) ) to take a look....
looking over the code, it seems the code makes an attempt to set the precision, just not to the full precision -- ```cpp template inline std::string NumToString(double t) { return...
so, just brute forcing this and making the change causes the tests to fail because `3.14159265359` gets rewritten to `3.14159265359000006` -- technically correct but more digits than necessary.
hey @ptitjes - thank you for the PR! It looks like there are some merge conflicts that have popped up. I don't think we have any kotlin experts helping maintain...
@bjornharrtell I noticed you were interacting with dependabot recently, is this something you could comment on?
ah I had just seen that you had approved #8779 and I think merged a different PR into that branch. I'm unsure who (of the active participants :D ) has...
I believe this is solved by #8547, and this is a duplicate of #8553, so closing as such.
@bjornharrtell (hope you don't mind me tagging you on so many issues :D )