Justin Davis comments

Results 81 comments of


                                            Justin Davis

[Rust] [Reflection] `get_field_vector()` only works for vectors of primitive types

reopening - I think this got closed by merge into the forked repo

[Rust] SafeTable is not publicly visible in reflection library

reopening this issue - looks like it got closed by a merge into the forked repo

Fixing Parser corruption after move (#8660)

closing for now as there is not enough information about if and why this might be necessary.

Update CMakeLists.txt

Overall I think this is a good PR to go in - but may I suggest a more descriptive cmake variable name? `FLATBUFFERS_INSTALL_RUNTIME_TO_BINDIR` -- its a bit more verbose but...

C++ Parser is corrupted after move

where is the actual issue you're seeing with these missing functions? The SymbolTable class seems to be a perfectly copyable object, it just needs to not outlive the Value objects...

C++ Parser is corrupted after move

closing for now as there is not enough information about if and why this might be necessary.

Improve performance of CreateSharedString by using std::unordered_set instead of std::set

Just for my curiosity - the standard library provides a hash for basic string, does FNV1a provide material performance or collision improvement over the compiler provided hash functions? My initial...

[Bazel] Implement `flatbuffers_library` and `cc_flatbuffers_library` build rules

@anton-bobukh I think it would be great to add some documentation surrounding this PR. I'm not sure where those docs should live, and am happy to merge these without, but...

[Rust] Map key encode as human-readable, but decoded as raw

@fawdlstty or @Muon if either of you want to take a stab at this one, feel free :D

[C++] Vtable deduplication fails for 64-bit buffers >2GB, causing slow serialization and larger buffers

not stale - PR opened.