jrhee17

There is no impact on the build itself, let me go ahead and merge this

command: ``` ./gradlew --no-daemon :benchmarks:jmh:clean :benchmarks:jmh:jmh -Pjmh.includes=grpc.downstream.DownstreamSimpleBenchmark.simple$ -Pjmh.params="clientType=NORMAL;useBlockingTaskExecutor=true,false" ``` Note: main branch: https://ge.armeria.dev/s/wrjaj3csesbe6 ``` Benchmark (clientType) (useBlockingTaskExecutor) Mode Cnt Score Error Units DownstreamSimpleBenchmark.simple NORMAL true thrpt 5 1425.960 ± 3.838...

> Hi Guys, also I signed the CLA, but it is still showing as pending, Is there anything else that I need to do in that area so that action...

Pushed a small commit which includes the following changes: - Add a `jsonLines` method for easier testing to `AnnotatedDocServiceTest` - Extract `validateJsonObject` so that multiple components can use it -...

> So, I think we should update this to the latest reporter and also add the "convenience dep" this makes version maintenance a lot easier as you can blindly update...

Armeria's gRPC module depends heavily on `grpc-java`. We'll probably move on to protobuf 26.0 once `grpc-java` also moves on. https://github.com/grpc/grpc-java/blob/34e241a60e7dd54195daaec3a16decae0dd702cc/gradle/libs.versions.toml#L8

> IIRC we chat about unhandled vs unlogged before and decided to go with unhandled. Did we change our mind? https://github.com/line/armeria/pull/4687#discussion_r1118460948 Sorry about causing the confusion 😅 I think I...

https://github.com/line/armeria/pull/5616#issuecomment-2060205298 Please also sign the CLA 🙇

Looking into the failing test, I guess there is a case where `Connection: close` header isn't sent but we set `needsDisconnection()` somewhere.

Went through the code, and I think the issue is the following: - The test failure occurs when `testTooLargeContentToNonExistentService` is run, and then `testStreamingResponseWithSlowClient` is run with HTTP1.1. The two...