jrhee17
jrhee17
> are you able to use full proto with your server? Actually ran into this issue due to a wrong dependency issue 😅 (which generated lite when I wasn't intending...
I'm not sure what the original request was as the slack post seems to have expired. Having said this, I think it could be meaningful if we can add an...
Ready for the next round of reviews 🙏
Can you check the CLA message and ensure that the email for the commits are registered with github? 
Can you check lints?
> I think we can assume that HttpJsonTranscodingOptions implies enabling HttpJsonTranscoding. I also think this API looks cleaner 👍 ``` GrpcService .builder() // Enable HttpJsonTranscoding and use the specified HttpJsonTranscodingOptions....
Seems like there is a genuine failure. Can you check? 😅 https://github.com/line/centraldogma/actions/runs/3135905322/jobs/5092148722#step:5:29 ``` FAILURE: Build failed with an exception. * Where: Script '/home/runner/work/centraldogma/centraldogma/gradle/scripts/lib/common-dependencies.gradle' line: 170 * What went wrong: A...
> *CentralDogma.meterRegistry and ClientFactory.meterRegistry might be different, > Shouldn't we warn in this case? I tried this out, but this means for the user either: 1) Provide the same `meterRegistry`...
rebased once - gentle ping, as I still think this PR has value
Ready for the next round of reviews 🙏