jrhee17

Thanks for the ping, left a comment

I see, my guess is that grpc doesn't use `WebClient` which our gRPC clients are using https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/93e06678168c5bce2c2a892685b06cceb8c1519d/instrumentation/armeria-1.3/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/armeria/v1_3/ArmeriaWebClientBuilderInstrumentation.java#L23 My guess is that the following might be a better injection point, but...

Left a comment 😄

Sorry about the late review, looks almost done! Can you check the following diff? ``` diff --git a/core/src/main/java/com/linecorp/armeria/server/healthcheck/CpuHealthChecker.java b/core/src/main/java/com/linecorp/armeria/server/healthcheck/CpuHealthChecker.java index 302154226..249999fe0 100644 --- a/core/src/main/java/com/linecorp/armeria/server/healthcheck/CpuHealthChecker.java +++ b/core/src/main/java/com/linecorp/armeria/server/healthcheck/CpuHealthChecker.java @@ -23,9 +23,11 @@...

Linking to https://github.com/line/armeria/pull/5370

closed by https://github.com/line/armeria/pull/4982

I'm not sure if this matches your use-case, but there is a similar known issue #4577 Does this match your issue? If it does, I think we agree but we...

> We still have BaseFlagsProvider which sets useOpenSsl to false by default, so only modifying DefaultFlagsPRovider#useOpenSsl method to return null won't work. `BaseFlagsProvider` is for an integration test, I'm not...

Honestly this sounds like more of an issue of Kotlin not supporting `@Inherited`. Having said this, I think adding `@Nullable` also to inherited methods is fine as long as we...

Note: confirmed the new changeset via https://github.com/jrhee17/armeria/actions/runs/6219845149/job/16878697488