Results 163 comments of jrhee17

> Is the following the correct order of precedence for applied headers? There are a couple places where the header can be set, but more or less I think the...

> mutateDefaultRequestHeaders() could be used by the headers updating decorator instead of .mapHeaders() for the dynamic headers. I assume you are suggesting a completely different design from the discussed one....

> I imagined that it would be easier to implement if WebClient provided AuthTokenProvider: () -> CompletableFuture that has the same priority as AuthToken. I agree having such an API...

Took a quick look through the API/source and looks promising! 👍 If I understood correctly, this can be a much simpler solution over `RequestContextHooks`

> If overridable is set to true, ArmeriaSettings will be applied before ArmeriaServerConfigurator is applied. So if `overridable: true`, then which settings will be overridable? I think we should clearly...

> If I wrote a novel... Let's say an ArmeriaServerConfigurator bean is injected by other modules or libraries. The code owner may not want ArmeriaServerConfigurator to change. But it would...

> @jrhee17 thanks for the review. Seems like I've already signed up the CLS as follows https://github.com/line/armeria/pull/4982#issuecomment-2028105601 Can you try modifying the authoring email of your commits so that we...

Looking back into this, I'm not sure if there is really much value in adding a meter for this particular scenario. Let me close this PR and revisit later

This PR has been stale for a while - I've added a commit to get it moving forward. Changes include: - Now, only a single header map is created, followed...