jrhee17
jrhee17
Note: `unwrapAll` and `unwrap` return types are inconsistent until 2.0.0 https://github.com/line/armeria/pull/4338#discussion_r923119208
Added a merge commit due to a conflict with my [PR](https://github.com/line/armeria/pull/4308)
Just for clarification: > Change the ResponseConverterFunctionProvider to use the configured responseConverterFunctions or to be applied after the responseConverterFunctions By this, I think we mean that we will define the...
Hi! Sorry about the late share 🙏 The following two PRs have been merged, so I think we can resume with this pull request. We can use ``` aCtx.unwrapAl() ==...
@heesuk-ahn Hi! Sorry about the late reply. Let me increase priority in getting this feature merged 🙇
Really sorry about the delay all 😅 I think this PR is finally in a reviewable state 🙏
@minwoox @ikhoon @trustin please take a look at #4426 before reviewing this PR 🙏
I think this is a good idea 👍 Maybe we can add an option at `HealthCheckServiceBuilder` whether to return a "verbose" health check response. We could make this option exclusive...
> support returning a Result object with state (boolean), optional message (string) and optional error (throwable) Curious about the distinction between `message` and `error`. I was original thinking `message` and...
> Both will work for the use-case as the goal is to communicate additional info about the health of a component. I see. Would it also make sense for your...